-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[RHACS] Added docs for explanations feature #95065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHACS] Added docs for explanations feature #95065
Conversation
🤖 Fri Jun 27 00:41:24 - Prow CI generated the docs preview: https://95065--ocpdocs-pr.netlify.app/ |
modules/retrieving-connectivity-mapping-information-from-a-kubernetes-manifest-directory.adoc
Outdated
Show resolved
Hide resolved
modules/retrieving-connectivity-mapping-information-from-a-kubernetes-manifest-directory.adoc
Outdated
Show resolved
Hide resolved
modules/retrieving-connectivity-mapping-information-from-a-kubernetes-manifest-directory.adoc
Outdated
Show resolved
Hide resolved
modules/retrieving-connectivity-mapping-information-from-a-kubernetes-manifest-directory.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding comments for updating examples text and with links to actual YAML configurations.
bc60026
to
8d264c0
Compare
|`--explain` | ||
|Enhance the analysis of permitted connectivity with explanations per denied/allowed connection; supported only for txt output format. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: For peer review, please ignore this change. It is the actual output from the CLI tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about this change:
why can't I see this update in the link for the table options here?
Also, why in this link the --exposure
option exists, but not in the table of this changed file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @adisos this was an older file which we don't use anywhere. I've updated the correct file n my recent commit to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added one more question.
|`--explain` | ||
|Enhance the analysis of permitted connectivity with explanations per denied/allowed connection; supported only for txt output format. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about this change:
why can't I see this update in the link for the table options here?
Also, why in this link the --exposure
option exists, but not in the table of this changed file?
8d264c0
to
0698656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighted a few issues; overall lgtm!
modules/retrieving-connectivity-mapping-information-from-a-kubernetes-manifest-directory.adoc
Outdated
Show resolved
Hide resolved
modules/retrieving-connectivity-mapping-information-from-a-kubernetes-manifest-directory.adoc
Outdated
Show resolved
Hide resolved
modules/retrieving-connectivity-mapping-information-from-a-kubernetes-manifest-directory.adoc
Outdated
Show resolved
Hide resolved
0698656
to
d0c39aa
Compare
d0c39aa
to
52f8459
Compare
@gaurav-nelson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick rhacs-docs-4.8 |
@gaurav-nelson: new pull request created: #95412 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
For https://issues.redhat.com/browse/ROX-29787
Added documentation for the new explainability feature.
Cherrypick in
rhacs-docs-4.8
.Preview: